FE: Create proto description of feature extractor service #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzz
reviewed
Mar 14, 2018
src/main/proto/service.proto
Outdated
|
|
||
| // The identifiers request message containing extractor configuration and uast. | ||
| message IdentifiersRequest { | ||
| bytes uast = 1; |
There was a problem hiding this comment.
One thing that we discussed is that we should be using a super-set of our existing UAST msg type.
This can be done by adding adding 2 files to our /proto/ dir
- https://github.com/bblfsh/client-scala/blob/master/src/main/proto/github.com/gogo/protobuf/gogoproto/gogo.proto
- https://github.com/bblfsh/sdk/blob/master/uast/generated.proto
and then
import "github.com/gogo/protobuf/gogoproto/gogo.proto";
import "gopkg.in/bblfsh/sdk.v1/uast/generated.proto";
and
uast gopkg.in.bblfsh.sdk.v1.uast.generated.Node = 1;
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
bzz
reviewed
Mar 14, 2018
bzz
changed the title
dpordomingo
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First point in #51
P.S. Tests correctness by running
and looking at source code.