Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala client integration test #81

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Scala client integration test #81

merged 3 commits into from
Apr 4, 2018

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Mar 27, 2018

Last task from #51

Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@bzz bzz mentioned this pull request Mar 27, 2018
7 tasks
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bzz bzz mentioned this pull request Apr 3, 2018
@carlosms carlosms self-requested a review April 3, 2018 16:19
Copy link
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

My only comment is that tags/FEIntegration.java could be called something more generic, like TestingTags, to be able to add new tags later.

@smacker
Copy link
Contributor Author

smacker commented Apr 4, 2018

We have quite many parts of the system. And they aren't very connected. We may even extract some of them to separate repositories later. So I would prefer having 1 file per sub-project than 1 huge file with everything.

But big thanks for the idea. It made me actually think how to tag tests better. It will be useful in query integration tests.

@smacker smacker merged commit c9c811e into src-d:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants