it: blobs per master commit #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
This was referenced Mar 13, 2018
erizocosmico
commented
Mar 13, 2018
integration_test.go
Outdated
| testCases := []struct { | ||
| query string | ||
| result []sql.Row | ||
| sortFunc rowSortFunc |
There was a problem hiding this comment.
Some queries, such as the aggregations can't be sorted using ORDER BY, so we need this to check some outputs :(
There was a problem hiding this comment.
Maybe you can use require.ElementsMatch instead of require.Equal to check the output
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
|
Fixed @ajnavarro |
ajnavarro
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
Just with master instead of HEAD. HEAD ref is not listed, have to check why, but for this purpose it doesn't matter which branch it is.