history_idx: do not visit a parent more than once #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where it can enter a cycle Signed-off-by: Javi Fontan <jfontan@gmail.com>
erizocosmico
approved these changes
Mar 16, 2018
internal/function/history_idx.go
Outdated
| newParents := make([]plumbing.Hash, 0, c.NumParents()) | ||
| for _, h = range c.ParentHashes { | ||
| _, ok = visitedHashes[h] | ||
| if !ok { |
There was a problem hiding this comment.
you can inline that as if _, ok := visitedHashes[h]; !ok
internal/function/history_idx.go
Outdated
| c, err := repo.CommitObject(frame.hashes[frame.pos]) | ||
| h := frame.hashes[frame.pos] | ||
| _, ok := visitedHashes[h] | ||
| if !ok { |
There was a problem hiding this comment.
you can inline that as if _, ok := visitedHashes[h]; !ok
Signed-off-by: Javi Fontan <jfontan@gmail.com>
|
The go-mysql-server broke API comp. We need another PR implementing String method and rebase here. |
ajnavarro
approved these changes
Mar 16, 2018
mcarmonaa
approved these changes
Mar 16, 2018
|
Travis was failing because you were caught in the middle of making it compatible with the new go-mysql-server. Restarted the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where it can enter a cycle