Catch errors creating new iteratos in rowReaders #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfontan
requested review from
smola,
ajnavarro,
erizocosmico,
mcarmonaa and
a team
kuba--
approved these changes
Apr 12, 2018
mcarmonaa
approved these changes
Apr 12, 2018
ajnavarro
reviewed
Apr 12, 2018
erizocosmico
approved these changes
Apr 12, 2018
smola
approved these changes
Apr 12, 2018
smola
suggested changes
Apr 12, 2018
| return | ||
| default: | ||
| i.setError(err) | ||
| close(i.done) |
There was a problem hiding this comment.
You need to continue to the next loop iteration. Otherwise, we'll still get a panic because of the iter == nil and never get the error.
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
|
Added test for this case and fixed the problem pointed by @smola. |
smola
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #215