gitbase: add support for siva files #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
requested review from
jfontan,
smola,
ajnavarro,
kuba-- and
mcarmonaa
smola
reviewed
Apr 12, 2018
cmd/gitbase/server.go
Outdated
| cmd | ||
|
|
||
| Git string `short:"g" long:"git" description:"Path where the git repositories are located, one per dir"` | ||
| Git string `short:"g" long:"git" description:"Path where the git repositories are located"` | ||
| Siva string `long:"siva" description:"PAth where the siva repositories are located"` |
smola
approved these changes
Apr 12, 2018
jfontan
approved these changes
Apr 13, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Add support in RepositoryPool for handling siva files as repositories. Added a new `AddSivaDir` method to `RepositoryPool`, which adds all the siva files inside that directory (a siva file is considered to be any file whose extension is `.siva`) and the direct child directories to allow bucketing. Also some minor changes related to the RepositoryPool: - NewRepositoryFromPath returns now *Repository for convenience. - NewRepositoryPool returns now *RepositoryPool, as it always needs to be used with a pointer. - Fixed golint warning about returning an unexported type in an exported method, which may be annoying by replacing the type with `sql.RowIter`. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
ajnavarro
approved these changes
Apr 13, 2018
| @@ -44,12 +45,12 @@ func (c *cmdServer) buildDatabase() error { | |||
| logrus.WithField("dir", c.Git).Debug("added folder containing git repositories") | |||
| } | |||
|
|
|||
| var err error | |||
| c.pool = gitbase.NewRepositoryPool() | |||
There was a problem hiding this comment.
so, now you can have mixed repositories on the same execution, standard ones and siva ones?
There was a problem hiding this comment.
Yup. I can restrict that if we want to only have one type
mcarmonaa
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216
Depends on #223 (will probably rebase and remove the dependency tomorrow)
Add support in RepositoryPool for handling siva files as repositories.
Added a new
AddSivaDirmethod toRepositoryPool, which adds all the siva files inside that directory (a siva file is considered to be any file whose extension is.siva) and the direct child directories to allow bucketing.Also some minor changes related to the RepositoryPool:
sql.RowIter.