gitbase: ignore .DS_Store files in darwin #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I believe that we can simplify this and do it for all OSs. It can happen that we copy repos from MAC to Linux and have the same problem. |
|
Yep, we can probably unify this |
jfontan
approved these changes
Jun 27, 2018
|
should we ignore all hidden files and folders? WDYT @jfontan @erizocosmico |
|
Regarding the comment from @ajnavarro in #341: we cannot ignore all hidden files and folders by default. They may have some meaning in the repository. Take into account |
|
Shall we merge this? |
|
@erizocosmico rebase please |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
|
Done |
|
@erizocosmico yes please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337