Skip to content

docs: add commit_files table to the schema documentation #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcarmonaa
Copy link
Contributor

@mcarmonaa mcarmonaa commented Jun 29, 2018

Closes #351

Signed-off-by: Manuel Carmona manu.carmona90@gmail.com

@mcarmonaa mcarmonaa requested a review from a team June 29, 2018 06:29
![gitbase schema](/docs/assets/gitbase-db-diagram.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change the diagram too.

@mcarmonaa
Copy link
Contributor Author

@ajnavarro the new diagram is already added

@erizocosmico
Copy link
Contributor

@ajnavarro what tool did you use to generate the ER diagram? There was a comment with the code to generate it, right? If we add there also the tool I think it's easier than having to use MySQL workbench and it's better for version control.

@ajnavarro
Copy link
Contributor

@erizocosmico the tool that I use has a 10 tables limit. Now we have 11.

@erizocosmico
Copy link
Contributor

Nvm then

@ajnavarro
Copy link
Contributor

@mcarmonaa the last thing: https://stackoverflow.com/questions/14946161/how-to-draw-relationship-lines-between-columns

To be able to see relationships between columns.

mcarmonaa added 2 commits July 3, 2018 12:39
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
@mcarmonaa mcarmonaa force-pushed the improvement/docs-add-commit-files-table branch from 3fe563f to ca2899d Compare July 3, 2018 10:39
@mcarmonaa
Copy link
Contributor Author

@ajnavarro rebased

@ajnavarro ajnavarro merged commit 255031e into src-d:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants