Skip to content

internal/rule: simplify switch true {...} to switch {...} #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2018
Merged

internal/rule: simplify switch true {...} to switch {...} #504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42e805b
internal/rule: simplify `switch true {...}` to `switch {...}`
quasilyte Oct 1, 2018
636327d
Merge branch 'master' into quasilyte/switchTrue
smola Oct 2, 2018
3e038db
Merge branch 'master' into quasilyte/switchTrue
ajnavarro Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/rule/squashjoins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ func removeRedundantCompoundFilters(
// isRedundantFilter tells whether the given filter is redundant for joining
// t1 with t2. t1 MUST be higher in the table hierarchy than t2.
func isRedundantFilter(f sql.Expression, t1, t2 string) bool {
switch true {
switch {
case t1 == gitbase.RepositoriesTableName && t2 == gitbase.RemotesTableName:
return isEq(
isCol(gitbase.RepositoriesTableName, "repository_id"),
Expand Down