Skip to content

regression: add Jenkinsfile #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2019
Merged

regression: add Jenkinsfile #668

merged 2 commits into from
Jan 14, 2019

Conversation

jfontan
Copy link
Contributor

@jfontan jfontan commented Jan 4, 2019

Only runs on master branch and it checks SCM twice a day. Uses the queries from _testdata/regression.yml.

Signed-off-by: Javi Fontan <jfontan@gmail.com>
@jfontan jfontan requested review from smola and a team January 4, 2019 15:11
Copy link
Contributor

@erizocosmico erizocosmico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being this so tied with our cluster config, should this be here in the public repo?

@jfontan
Copy link
Contributor Author

jfontan commented Jan 4, 2019

We use a type of Jenkins job that discovers Jenkinsfile in repositories and runs whatever they have in. This lets us configure Jenkins once and add these files to repositories to enable these type of tests. AFAIK there is no way of merging parts hardcoded with the steps specific to projects, for example taking out the kubernetes part from this file.

We can go the other way and create Jenkins jobs per repository but this becomes tedious as any change to the Jenkinsfile or adding new repositories means changing Jenkins deploy recipes and deploying it again.

If this file seems out of place we can change its name or move it to another directory, for example .srcd-ci/Jenkinsfile.

@smola
Copy link
Contributor

smola commented Jan 8, 2019

AFAIK there is no way of merging parts hardcoded with the steps specific to projects, for example taking out the kubernetes part from this file.

As discussed offline, there is nothing here that we need to keep secret. Other than that, we'll eventually refactor these Jenkinsfile to use a shared library, to reduce boilerplate.

@ajnavarro ajnavarro merged commit 313b043 into src-d:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants