Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go-borges] cli: added support to specify format per directory #867

Merged
merged 4 commits into from
Jun 17, 2019

Conversation

jfontan
Copy link
Contributor

@jfontan jfontan commented Jun 14, 2019

Global format can be specified with --format, --bare, --bucket and --rooted. To mix directories the format can be specified as a file URL:

-d file:///path/to/library?format=siva&bucket=4&rooted=false

Also:

  • Updated builder container to go 1.12
  • Added SIVA env to docker init.sh to configure gitbase to use siva library
  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I added or updated examples if applicable.

Fixes #866

Global format can be specified with --format, --bare, --bucket and
--rooted. To mix directories the format can be specified as a file URL:

    -d file:///path/to/library?format=siva&bucket=4&rooted=false

Also:

* Updated builder container to go 1.12
* Added SIVA env to docker init.sh to configure gitbase to use siva
library

Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
@ajnavarro ajnavarro requested a review from a team June 14, 2019 10:52
docs/using-gitbase/configuration.md Show resolved Hide resolved
* `--format`: it can be either `git` for filesystem repositories or `siva` for siva archives
* `--bare`: specifies that git archives are bare, can only be used with `git` format
* `--bucket`: sets the number of characters to use for bucketing, used with `siva` libraries
* `--rooted`: enables or disables rooted reposotories management in `siva` libraries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo repositories

}

val := v[0]
switch k {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings.ToLower - WDYT?

@jfontan jfontan changed the title cli: added support to specify format per directory [go-borges] cli: added support to specify format per directory Jun 14, 2019
Fixed documentation, typos and erroneous messages. Also library URL
parameters are converted to lowercase before parsing.

Signed-off-by: Javi Fontan <jfontan@gmail.com>
@ajnavarro ajnavarro changed the title [go-borges] cli: added support to specify format per directory [go-borges] cli: added support to specify format per directory Jun 17, 2019
@ajnavarro ajnavarro merged commit 221f4ba into src-d:go-borges-integration Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants