Skip to content

Update go-mysql-server dependency #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Oct 22, 2019

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

  • I updated the documentation explaining the new behavior if any.
  • I updated CHANGELOG.md file adding the new feature or bug fix.
  • I updated go-mysql-server using make upgrade command if applicable.
  • I added or updated examples if applicable.
  • I checked that changes on schema are reflected into the documentation, if applicable.

@ajnavarro ajnavarro requested a review from a team October 22, 2019 09:41
Copy link
Contributor

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the DROP/CREATE table support? src-d/go-mysql-server#845

CHANGELOG.md Outdated
Comment on lines 12 to 13
- Removed redundant commit information from BLAME results.
- Don't abort, just warn, on git.Blame errors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If BLAME is a new function, does it make sense to add these 2 as fixes over the last release?

@ajnavarro
Copy link
Contributor Author

@agarciamontoro drop/create are not supported on gitbase.

@ajnavarro ajnavarro force-pushed the GMS-update-221019 branch 3 times, most recently from ed46225 to 14c767c Compare October 22, 2019 15:52
Copy link
Contributor

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop/create are not supported on gitbase.

You're right, my bad.

@erizocosmico
Copy link
Contributor

@ajnavarro can you rebase?

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro
Copy link
Contributor Author

@erizocosmico rebased

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@erizocosmico erizocosmico merged commit a07e10b into src-d:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants