This repository was archived by the owner on Sep 11, 2020. It is now read-only.
utils: fs.TempFile #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcuadros
commented
Oct 18, 2016
mcuadros
commented
- New fs.TempFile method in the fs.Filesystem interface, this abstraction is required to filesystem where the creation of a temporal file should be explicit
- utils.fs: new TestSuite for test any fs.Filesystem implementation
smola
approved these changes
Oct 18, 2016
alcortesm
suggested changes
Oct 19, 2016
| fs Filesystem | ||
| } | ||
|
|
||
| func (s *FilesystemSuite) TestCreate(c *C) { |
There was a problem hiding this comment.
Create should truncate files if they already exists, I don't think that behavior is being tested.
utils/fs/os.go
Outdated
| type OS struct { | ||
| RootDir string | ||
| base string | ||
| tempfiles []string |
There was a problem hiding this comment.
Is this unused?
The name should be tempFiles.
utils/fs/os.go
Outdated
|
|
||
| func (fs *OS) TempFile(dir, prefix string) (File, error) { | ||
| fullpath := fs.Join(fs.base, dir) | ||
| if err := fs.createDir(fullpath + "/"); err != nil { |
There was a problem hiding this comment.
Is "/" portable? should be os.PathSeparator?
| } | ||
|
|
||
| fr, err := fs.Open(tmp) | ||
| fr, err := fs.Open(fw.Filename()) |
There was a problem hiding this comment.
TempFile already returns a File, do we really need to open it again?
There was a problem hiding this comment.
yup, as I explained in RealWorld
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
* utils: fs generic TestSuite * fs: fs.TempFile * utils: fs small changes requested * utils: fs, test fs.Create overwriting files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.