do not query again if result is less than limit #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a query returned less rows than the limit, it would make an additional query and then it would mark the batcher as EOF. This change takes care of that case and makes sure no additional query is made. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 79.12% 79.22% +0.09%
==========================================
Files 19 19
Lines 3646 3653 +7
==========================================
+ Hits 2885 2894 +9
+ Misses 546 545 -1
+ Partials 215 214 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
If a query returned less rows than the limit, it would make an additional query and then it would mark the batcher as EOF.
This change takes care of that case and makes sure no additional query is made.