Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Make count int64 function #643

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Make count int64 function #643

merged 1 commit into from
Apr 1, 2019

Conversation

kuba--
Copy link
Contributor

@kuba-- kuba-- commented Mar 21, 2019

Signed-off-by: kuba-- kuba@sourced.tech
Closes #642

Make count int64 function:x
184b584 
Signed-off-by: kuba-- <kuba@sourced.tech>
@kuba-- kuba-- requested a review from a team March 21, 2019 23:37
@kuba-- kuba-- added the proposal proposal for new additions or changes label Mar 21, 2019
@kuba-- kuba-- changed the title Make count int64 function:x Make count int64 function Mar 21, 2019
erizocosmico
erizocosmico approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@erizocosmico erizocosmico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuba-- Did you check all other aggregations so they return Int64 as well?

@kuba--
Copy link
Contributor Author

kuba-- commented Mar 22, 2019 •
edited
Loading

@erizocosmico - the rest of stuff looks good (float64). The only one with int32 is array_length, but I think this is fine.

@ajnavarro ajnavarro merged commit 8141017 into src-d:master Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@erizocosmico erizocosmico erizocosmico approved these changes

Assignees
No one assigned
Labels
proposal proposal for new additions or changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuba-- @ajnavarro @erizocosmico