This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
server: correctly set binary charset on blob fields #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, there was an incorrect comparison to check whether the field was a blob or not. That resulted in all fields, including blobs, having the UTF8 charset. Now all fields have UTF8 charset except for BLOBs, which have binary charset. Also, a test has been added to ensure a correct behaviour. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
kuba--
approved these changes
Apr 12, 2019
ajnavarro
approved these changes
Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, there was an incorrect comparison to check whether the
field was a blob or not. That resulted in all fields, including
blobs, having the UTF8 charset. Now all fields have UTF8 charset
except for BLOBs, which have binary charset.
Also, a test has been added to ensure a correct behaviour.
Signed-off-by: Miguel Molina miguel@erizocosmi.co