Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

sql: use correct MySQL display name for types #704

Merged
merged 1 commit into from
May 8, 2019
Merged

sql: use correct MySQL display name for types #704

merged 1 commit into from
May 8, 2019

Conversation

erizocosmico
Copy link
Contributor

Fixes #702

@erizocosmico erizocosmico requested a review from a team May 7, 2019 11:06
kuba--
kuba-- approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DATETIME <-> TIMESTAMP left (based on failing tests). Otherwise (if tests pass) - OK

@erizocosmico
sql: use correct MySQL display name for types
dee5051 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

Fixed

@erizocosmico
Copy link
Contributor Author

Shall we merge this @ajnavarro?

@erizocosmico erizocosmico merged commit 756e3bf into src-d:master May 8, 2019
@erizocosmico erizocosmico deleted the fix/type-display-name branch May 8, 2019 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanjux juanjux juanjux approved these changes

@kuba-- kuba-- kuba-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type name for int64 in create table
3 participants
@erizocosmico @juanjux @kuba--