Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

sql/expression/function: implement char_length and length functions #724

Merged
merged 1 commit into from
May 24, 2019
Merged

sql/expression/function: implement char_length and length functions #724

merged 1 commit into from
May 24, 2019

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented May 23, 2019 •
edited
Loading

Fixes #715

@erizocosmico erizocosmico requested a review from a team May 23, 2019 14:39
ajnavarro
ajnavarro reviewed May 23, 2019
View reviewed changes
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add this functions to the docu?

juanjux
juanjux reviewed May 23, 2019
View reviewed changes
sql/expression/function/length_test.go
"gopkg.in/src-d/go-mysql-server.v0/sql/expression"
)

func TestLength(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a test with an empty string.

@erizocosmico erizocosmico force-pushed the feature/length branch 2 times, most recently from db82def to 919e1dc Compare May 24, 2019 09:00
@erizocosmico
Copy link
Contributor Author

All fixed

@juanjux
Copy link
Contributor

juanjux commented May 24, 2019

LGTM, needs rebase.

@erizocosmico
Copy link
Contributor Author

Rebased

@erizocosmico
sql/expression/function: implement char_length and length functions
84257ce 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@ajnavarro ajnavarro merged commit 48de158 into src-d:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanjux juanjux juanjux approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add LENGTH function (for strings)
4 participants
@erizocosmico @juanjux @ajnavarro @kuba--