Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Don't reconnect to bblfsh or analyzer #34

Merged
merged 1 commit into from
Jul 20, 2018
Merged

SDK: Don't reconnect to bblfsh or analyzer #34

merged 1 commit into from
Jul 20, 2018

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Jul 19, 2018

Part of #29

Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker requested review from carlosms and bzz July 19, 2018 14:38
@bzz bzz mentioned this pull request Jul 20, 2018
3 tasks
@carlosms
Copy link
Contributor

This is great if you are developing an analyzer that doesn't need UAST, but if you do need it, and fail to connect lookout to bblfsh properly, the current code will ignore req.WantUAST silently, right?

A single warning at startup will be easy to miss if the requests themselves return success, but with unexpected contents. I think a request with wantUAST should fail, with an error message that informs that lookout could not connect to bblfsh.

@carlosms
Copy link
Contributor

Another option I can think of is to make --bblfshd optional, and if it is set make lookout try to connect once, print the error and exit.

@bzz
Copy link
Contributor

bzz commented Jul 20, 2018

👍 on @carlosms suggestions, it's important to get SDK UX right, so users have trust it in.
Let's address it.

@smacker
Copy link
Contributor Author

smacker commented Jul 20, 2018

I would prefer to implement in separate PR to unblock sequential PRs and don't make this PR too huge. Here is an issue: #45

Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, with handling improvements in separate PR

@bzz bzz mentioned this pull request Jul 20, 2018
@smacker smacker merged commit 2327a4c into src-d:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants