Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with GHC 9.8 #2

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Allow building with GHC 9.8 #2

merged 2 commits into from
Mar 3, 2024

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 2, 2024

This shifts the upper bound on the base package, closes #1.

I've built successfully with ghc-9.6.4 and ghc-9.8.2.

@rvl
Copy link
Contributor Author

rvl commented Mar 2, 2024

The upper bound on base could just be relaxed to <5, that might be easier.

@rvl
Copy link
Contributor Author

rvl commented Mar 2, 2024

Do you also need a url-slug.cabal version increment and changelog entry? I would think not because since it's just a dependency bounds change, this can just be edited on Hackage.

This shifts the upper bound on the base package.
@srid
Copy link
Owner

srid commented Mar 2, 2024

this can just be edited on Hackage.

Okay I just did that: https://hackage.haskell.org/package/url-slug-0.1.0.0

image

url-slug.cabal Outdated Show resolved Hide resolved
Co-authored-by: Sridhar Ratnakumar <3998+srid@users.noreply.github.com>
@rvl
Copy link
Contributor Author

rvl commented Mar 3, 2024

Thanks @srid 👍

@srid srid merged commit 6fc48ac into srid:master Mar 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too strict version bound on base for ghc 9.6
2 participants