Re-Enable default goto popup #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification re-enables the default goto popup when "enable_tooltip" is set to false. In this moment jedi only sets the "show_definitions" setting to False when "enable_tooltip" is True but it never reset it back when you set it to False causing the default popup to never show up ever again (you have to enable it manually)
|
Wow! Thanks a lot 👍 |
|
no problem. Happy to contribute. |
|
I am afraid that this makes conflicts with the preference option that is specified by either the user or another plugin. A scenario is that one has an LSP plugin that maintain its own hover popups, and always sets this option to false upon switching to the view it manages, and there would be a race condition. Perhaps you need to remember the old setting and restore it in this case, instead of setting it to true? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification re-enables the default goto popup when "enable_tooltip" is set to false.
In this moment jedi only sets the "show_definitions" setting to False when "enable_tooltip" is True but it never reset it back when you set it to False causing the default popup to never show up ever again (you have to enable it manually)