-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appendOnly: true
doesn't seem to work
#104
Labels
bug
Something isn't working
Comments
Thanks for reporting it @jrfnl , I will look into this |
@srvaroa Much appreciated! |
jrfnl
added a commit
to PHPCSStandards/PHP_CodeSniffer
that referenced
this issue
Nov 10, 2023
... to prevent running into a bug which I've reported to the action runner: srvaroa/labeler#104 The default pull request template contain a categorization section anyway (which is not typically used for maintainer PRs), so let's use that section to auto-label the "Type" for new PRs.
jrfnl
added a commit
to PHPCSStandards/PHP_CodeSniffer
that referenced
this issue
Nov 10, 2023
... to prevent running into a bug which I've reported to the action runner: srvaroa/labeler#104 The default pull request template contain a categorization section anyway (which is not typically used for maintainer PRs), so let's use that section to auto-label the "Type" for new PRs.
Thank you @srvaroa ! I'm currently working on another workflow, once that's done, I'll switch this one to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm experimenting with this action at the moment and noticed the following:
Given a
labeler.yml
file containing the following:This happens:
When a new PR is opened and the
Type: bug
label is manually added, but the body of the PR does not contain the term "bug" (though the title does), theType: bug
label is removed from the PR by the workflow.Same thing with the
Type: documentation
label. If this was manually added on creating the PR, the workflow removes it when thefiles
regex doesn't match any files.While I expected:
... the
appendOnly: true
setting to prevent this from happening.Please let me know if you need more information and thank you for creating this action runner!
The text was updated successfully, but these errors were encountered: