Skip to content

Conversation

qnighy
Copy link
Member

@qnighy qnighy commented Mar 3, 2020

Upgrade github.com/srvc/fail for:

  • Better go modules integration.
  • Newest features from srvc/fail.

@qnighy qnighy requested a review from izumin5210 March 3, 2020 09:26
@qnighy
Copy link
Member Author

qnighy commented Mar 3, 2020

Note, this is technically a breaking change because we use fail.Error in our interface.

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   56.48%   56.48%           
=======================================
  Files           5        5           
  Lines         108      108           
=======================================
  Hits           61       61           
  Misses         46       46           
  Partials        1        1
Impacted Files Coverage Δ
unary_server_error_handlers.go 91.66% <ø> (ø) ⬆️
stream_server_error_handlers.go 0% <ø> (ø) ⬆️
handlers.go 90.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249f210...6b83c27. Read the comment docs.

@qnighy qnighy merged commit 130c5ec into master Mar 9, 2020
@qnighy qnighy deleted the qnighy/fail-4.1.1 branch March 9, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants