Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filenames in train_ctc_tf_ml.sh #170

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

xinjli
Copy link

@xinjli xinjli commented Jan 30, 2018

Fix some filename issues in tf_clean steps/train_ctc_tf_ml.sh, so that tf babel script can run without crashing

Copy link

@ramonsanabria ramonsanabria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should do this open for any of the datasets used (we are currently using this for swbd also).

Also, the *tr.gz is the format that we use for the labels originally (I was skipping this before). We should leave gzip for now.

But it would be cool if you can to it general like: accept _nodup and _tr. Thanks!

@xinjli
Copy link
Author

xinjli commented Jan 31, 2018

I see, I was trying to make the script work for babel dataset and did not consider swbd case. Do you mean that I can push the first two changes: change_dev into _cv and _nohup into _tr, and should not touch the remaining part? Thanks!

@fmetze
Copy link
Contributor

fmetze commented Jan 31, 2018 via email

@ramonsanabria
Copy link

ramonsanabria commented Jan 31, 2018 via email

@xinjli
Copy link
Author

xinjli commented Jan 31, 2018

OK, thanks!

@ramonsanabria ramonsanabria merged commit 280d01a into srvk:tf_clean Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants