Save every 100 batches. #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to open the ark/ scp files in "append mode" (not sure if it is). I think it is not ideal to have potentially many small files laying around when we don't parallelize the output, but we only save on memory. |
|
No, the solution for that was using hdf5. The problem for that is that we
can not keep the .ark in memory.
2018-06-18 23:28 GMT-04:00 Florian Metze <notifications@github.com>:
… Would it be possible to open the ark/ scp files in "append mode" (not sure
if it is). I think it is not ideal to have potentially many small files
laying around when we don't parallelize the output, but we only save on
memory.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#186 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMlwPeEvN-eL_-mGt95qh6mOGd7HErJZks5t-G_7gaJpZM4UlhSi>
.
|
|
Hmm, The writeark seems to be working in append mode.. It might actually be possible. Let me check |
I think this would append, along with srvk/eesen#187
|
Not sure why you added this (100 batches save mode). Can you explain a bit
please ?
Also, if this have to be in the repo. Wouldn't be better as an option?
Thanks
2018-06-18 23:49 GMT-04:00 Siddharth Dalmia <notifications@github.com>:
… ok, @fmetze <https://github.com/fmetze> could you check this, along with
#187 <#187> ? It should do the append.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#186 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMlwPbunHElYFprXr2FdYTv3aH2VzKRRks5t-HTBgaJpZM4UlhSi>
.
|
|
I don't have a test setup ready. I think it would be best to make it an option, and if that has been enabled, write out the file in multiple batches, appending to the big file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.