[WIP] add some missing ssb-gossip config (without README) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
changed the title
|
@mixmix what about #39 ? |
|
Although, I can certainly see the advantage of having aggregate documentation for all configuration options. |
mixmix
commented
Feb 12, 2019
| @@ -27,7 +27,11 @@ module.exports = function setDefaults (name, config) { | |||
| hops: 3 | |||
| }, | |||
| gossip: { | |||
| connections: 3 | |||
| connections: 3, | |||
There was a problem hiding this comment.
TODO - remove connections, it seems to not be used anywhere!
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
This thread is still relevant
…On Mon, 13 May 2019, 17:58 stale[bot], ***@***.***> wrote:
Is this still relevant? If so, what is blocking it? Is there anything you
can do to help move it forward?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAUK3HVET5DKWZ56W5NZ4SDPVD7O3ANCNFSM4GWLWUKA>
.
|
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are more options that
ssb-configreads ... I don't know what they are, they're not really documented in theapi.md... I don't know if they should be in here.Putting them in the
defaults.jsis a start .. ?