-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Documentation #70
Conversation
config.remote is used by ssb-client to make its server connection. It needs to be a multiserver address. |
|
|
I think the
this is a kinda advanced use case but is a really nice feature for unix-based systems |
README.md
Outdated
- `local` *(Boolean)* ... TODO | ||
- `friends` *(Boolean)* ... TODO | ||
- `global` *(Boolean)* ... TODO | ||
- `local` Enable synchronize with random local peers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be good to specifiy that local means "on the same local network as you"
README.md
Outdated
- `global` *(Boolean)* ... TODO | ||
- `local` Enable synchronize with random local peers | ||
- `friends` Establish connections with peers who are friends | ||
- `global` Do not restrict who you connect with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these settings need more clarification.
Like if you set global: true
, then does that over-ride local: false
? your description here suggests that. I think this is more about making connections with people not on the local network. ... but then I don't know what that "friends" option is about...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so I made some changes in relation to gossip. I had to read the code to see how the settings affected performance.
I also changed the information about remote, but I still have doubts with the timers, I can't find any code that uses timers.connections and timers.reconnect
README.md
Outdated
* `remote` ... TODO ... a multisever address for ... (in the future this may be deprecated / derived from `connections` | ||
__Options__ | ||
* `connections` *(object)* Details `incoming` and `outgoing` connections behaviour ([See below](#connections)). | ||
* `remote` *(string)* Multiserver address to connect as a client. Useful in some cases, such as using [ssb-unix-socket](https://github.com/ssbc/ssb-unix-socket) + [ssb-no-auth](https://github.com/ssbc/ssb-no-auth). In the future this may be deprecated / derived from `connections`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right place to mention this (but it has bitten me before), when entering the public key in the multiserver address, you need to make sure you don't have the public key type in there, as otherwise ssb-client will fail with cryptic errors. Most probably a bug, but until it gets fixed, might be good to mention here.
So, the multiserver address has to be something like ws://127.0.0.1:8989~shs:@FlzOOyrhTG+Cl6YND5tReJtd2ufUj3++F0ZsfcPalRc=
(missing .ed25519
that seems to be optional in all other places but in a multiserver address)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @victorb, I added the link to the definition of multiserver address.
The address you were trying (with the key type at the end) is not considered a valid address.
Improve reading in some text editors
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Anything stopping this from being merged? @gmarcos87 |
Time to review it! If you recommend it, then that's enough for you to merge + publish a new version ?
…On Aug 3 2020, at 7:40 pm, Anders Rune Jensen ***@***.***> wrote:
Anything stopping this from being merged?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (#70 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAUK3HRUEIZ7OL4F6Z6TQD3R6ZSYTANCNFSM4KIIDHQA).
|
Alright, did a review and the changes looks good to me. I have made another commit with some minor changes after the merge as this branch was not in this repo. |
I want to update the ssb-config but I found some doubts with some values of the configuration.
The options I would like more information about are:
These options I could not find where they are used, maybe they are deprecated or I did not search well
I also added the options for ssb-party, timers.keepalive and timers.inactivity
Maintenance Grant (%dka5LyifpeWotdE1LxNGmbk1Jtwme0RUlA0LhfM0blQ=.sha256)