-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicitly ignore errors #246
Conversation
Oh that was what I was seeing on my pub after upgrading to latest version. Thanks for fixing this! |
These changes weren't made by On a constructive note, I'd love to learn more about why we're ignoring these sorts of errors so that I don't make this mistake in the future. If you could help me understand why these errors are fine to ignore I'd be happy to add a comment to the file documenting it.
|
@christianbundy I'm sorry I didn't intend it like that. I guess I'm just trying to say that standard encouraged some changes that were then made without full understanding of what they did. (false positive) Basically, in a distributed system or a database sometimes we expect errors. It does look like a JSON error, but also, there is test coverage for the migration code, so I'm confidant it works. I think maybe that error just happens when it's empty. hmm, maybe it should use an explicit |
hmm, if that is correct... then this might actually be broken for real migrations... |
hmm, yes there might actually be a problem here... but there must be hardly any instances that havn't already migrated (someone who kicked the tires a few years ago, and then come back) they can always resync. better to just remove the legacy migration stuff than figure out what version of level broke it, etc... |
I take back what I say about it being a false positive @christianbundy. |
hey @dominictarr you merged this but didn't publish. I've assumed that's an oversight, and gone ahead and published this as a patch release. If this is horribly wrong, please let me know |
is behaving fine in production for me |
thanks @mixmix |
ssb-server
doesn't even start for me (with current master branch)but the problem was just these throws where added in e185284 to support
standard
. let the record show that adopting standard caused bugs.