-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Butt2 #343
Conversation
@staltz just to align. I'm not in a rush with this and ssbc/ssb-ebt#67. So I'll be happy to wait with this until you do the refactor of formats and encryption. I mostly have what I need here to test. Also I'd like to split this into another PR, there is a separate part of this that improves performance of encrypted messages for classic. About the node 12 and 14 tests not working, I think it might be related to npm install never finishing:
uuid comes from:
|
@arj03 Thanks! I'm actually not sure which way will be easier: merging this now, or resolving conflicts later. It might be complicated any way. If you're not blocked, then maybe let me try to do the format&encryption PR first, and then if resolving conflicts here is too hard, it's not going to be hard for me to write a new PR to add buttwoo using the new format&encryption API.
Oh yeah, that one is still a mystery. It actually does complete, if you would wait a long time (CI was set to maximum 10min). And it's not related to |
Almost ready, need to do something about
buttPost
.