Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butt2 #343

Closed
wants to merge 8 commits into from
Closed

Butt2 #343

wants to merge 8 commits into from

Conversation

arj03
Copy link
Member

@arj03 arj03 commented May 16, 2022

Almost ready, need to do something about buttPost.

@arj03 arj03 mentioned this pull request May 25, 2022
@arj03
Copy link
Member Author

arj03 commented May 26, 2022

@staltz just to align. I'm not in a rush with this and ssbc/ssb-ebt#67. So I'll be happy to wait with this until you do the refactor of formats and encryption. I mostly have what I need here to test. Also I'd like to split this into another PR, there is a separate part of this that improves performance of encrypted messages for classic.

About the node 12 and 14 tests not working, I think it might be related to npm install never finishing:

npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.

uuid comes from:

ssb-db2@4.1.2 /home/arj/dev/ssb-db2
└─┬ ssb-fixtures@3.0.4
  └─┬ pull-stream-util@0.1.2
    └─┬ request@2.88.2
      └── uuid@3.4.0

@staltz
Copy link
Member

staltz commented May 26, 2022

@arj03 Thanks! I'm actually not sure which way will be easier: merging this now, or resolving conflicts later. It might be complicated any way. If you're not blocked, then maybe let me try to do the format&encryption PR first, and then if resolving conflicts here is too hard, it's not going to be hard for me to write a new PR to add buttwoo using the new format&encryption API.

About the node 12 and 14 tests not working, I think it might be related to npm install never finishing

Oh yeah, that one is still a mystery. It actually does complete, if you would wait a long time (CI was set to maximum 10min). And it's not related to uuid, try running npm install --verbose and you'll see where it gets slow. It's related to the repos we moved from ssb-ngi-pointer to ssbc but I don't know why.

db.js Show resolved Hide resolved
db.js Show resolved Hide resolved
db.js Show resolved Hide resolved
@arj03 arj03 closed this Jul 22, 2022
@arj03 arj03 deleted the butt2 branch July 28, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants