Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster ebt for encrypted messages #345

Merged
merged 1 commit into from
May 26, 2022
Merged

Faster ebt for encrypted messages #345

merged 1 commit into from
May 26, 2022

Conversation

arj03
Copy link
Member

@arj03 arj03 commented May 26, 2022

There is no need to first decrypt the message and then reEncrypt them ;)

There is a test here for that case. Just so we are sure this is not breaking anything.

staltz
staltz approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

CI is an annoying state, I wish I knew how to fix it. I installed and tested with node 12.x locally just to be sure. It's passing 👍

@arj03
Copy link
Member Author

arj03 commented May 26, 2022

Benchmarks here for comparison. This is for a feed where all messages are encrypted:

# classic performance before
ok 1 wait for replication to complete
after 3000 ms bob has 6336
^C
arj@arj:~/dev/ssb-ebt$ node test/formats.js
TAP version 13
# classic performance after
ok 1 wait for replication to complete
after 3000 ms bob has 8598

@arj03 arj03 merged commit f0a0c30 into master May 26, 2022
@arj03 arj03 deleted the faster-ebt branch May 26, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staltz staltz staltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arj03 @staltz