Faster single add #352
Merged
Faster single add #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Faster buttwoo validate * Cache some more in buttwoo * Refactor
staltz
reviewed
Jun 13, 2022
|
Should be ready now :) |
|
Awesome |
|
I think we can start looking at the uri changes e.g. now and see if we can add some of the things back |
|
URI changes, you mean the buttwoo URI with author+parent? And, add which things back? |
|
Hmm, the link just points me to the whole PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add()is used in EBT so should be as fast as possible, this avoids some overhead. classic add goes from 8400 to 8800 with this change.