Remove sublevel #15
Merged
Remove sublevel #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Our npm dependencies are outdated and I'd like to have Level 6. Solution: Upgrade all of the packages and run `npm update`.
Problem: This dependency is unmaintained and not really necessary. It allows us to embed multiple Level database instances in one, but we don't actually need that for any reason. This module is the source of an `npm audit` warning, and also may be the source of a new bug that's been happening in Oasis. Solution: Don't do that, and let level have its own database. The only problem is that **any pending invites will be ignored** because this commit doesn't include a migration script. This is fine for users to upgrade to, but pubs that still have lots of pending invites (?) may want to wait until their invites are redeemed (or write a migration script). Fixes: #13
|
I would merge this, but curious to hear from someone who maintains/runs a pub. I don't. By the way, I made this package for the client-only part of ssb-invite: https://github.com/staltz/ssb-invite-client (useful for apps that don't generate these invite codes) |
I maintain two pubs, fwiw. Is there someone you'd like to ping? |
|
@christianbundy nice1. I'll try testing this tonight and report back. |
|
I have now test this 👍. Lets get this merged and release @christianbundy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: This dependency is unmaintained and not really necessary. It
allows us to embed multiple Level database instances in one, but we
don't actually need that for any reason. This module is the source of an
npm auditwarning, and also may be the source of a new bug that's beenhappening in Oasis.
Solution: Don't do that, and let level have its own database. The only
problem is that any pending invites will be ignored because this
commit doesn't include a migration script. This is fine for users to
upgrade to, but pubs that still have lots of pending invites (?) may
want to wait until their invites are redeemed (or write a migration
script).
Fixes: #13
Depends on #14, although I could backport this change to the current
masterif necessary.