Better checks and more error handling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this should throw. |
|
@mmckegg can you add this module to https://github.com/ssbc/ssbc-owners so someone can merge and publish this? |
|
Right, thanks for catching that. I just wanted better error for when things go sour instead of silently ignoring them. I'll note that the other place where it catching an exception it does throw in the explain. |
|
@dominictarr added to ssbc-owners! (as well as a few others that were missing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was digging around the source, trying to find out why ssbc/ssb-server#417 doesn't work for me. I found what looks type a missing typeof bug and added some more error handling.