Rename internally used deprecated functions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This looks really great. I've just had another idea, maybe hare-brained, but do we need to prepend exports.parseAddress = deprecate('ssb-ref.parseAddress', parseAddress)
exports.parseMultiServerInvite = deprecate('ssb-ref.parseMultiServerInvite', parseMultiServerInvite)Sorry I've just now thought of this, if you think it's a good idea but don't have the time/energy I'd be happy to pull in your commit and add my above changes. What do you think? |
|
That's a great idea 😄 I'll take care of it |
|
Looks great, thanks! Sorry this took me so long to merge, I really appreciate this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toLegacyAddress - deprecated export
parseMultiServerAddress - undeprecated since it is not exported
parseLegacyInvite - nothing changed as only the export is deprecated
parseMultiServerInvite - nothing chagned as only the export is deprecated
parseInvite - nothing changed, export+function is deprecated and it is not called internally
parseAddress - undeprecated function, deprecated export (changed internal call to call function directly)