Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add savannah.gnu.org (cgit) support #34

Closed
wants to merge 1 commit into from

Conversation

itorres
Copy link

@itorres itorres commented Aug 6, 2016

The main difference is the modification in git-link-remote-regex since cgit instances don't necessarily have an username part and even in savannah.gnu.org some projects live in the git root (for example: http://git.savannah.gnu.org/cgit/guix.git/)

@sshaw
Copy link
Owner

sshaw commented Aug 6, 2016

Hi @itorres, thanks for this commit.

Support for Savanah has been discussed before and my feelings can be found here.

Support for cgit would be great (🎆 🎉 ❗) but there's a small quirk.
How do you propose dealing with this?

I think I created a branch locally to simply service creation and better deal with different url formats by allowing one to do things like this:

(add-to-list 'git-link-remote-alist 
  '("foo.com" "http://{hostname}/cgit.cgi/{dirname}}/commit?id={{commit}}"))
(add-to-list 'git-link-remote-alist 
  '("example.com" old-style-funtion))

But it's not done.

Also can you rebase against the url-with-port branch master and fix your regex additions to match it. That branch resolves #32.

Thanks!

("bitbucket.org" git-link-commit-bitbucket)
("gitorious.org" git-link-commit-gitorious)
("gitlab.com" git-link-commit-github)
("git.savannah.gnu.org" git-link-commit-cgit))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how one cloned the repo, the remote can also point to git.sv.gnu.org.

@sshaw
Copy link
Owner

sshaw commented Sep 25, 2019

Would be great to have cgit support. Please feel free to reopen if the outstanding issues/questions can be resolved.

@sshaw sshaw closed this Sep 25, 2019
@sshaw sshaw mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants