Tests: fix missing PermitTTY in RemoteSshdConfig Reset #1710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a test failure in
Common_CreateMoreChannelsThanMaxSessions
when running the tests multiple times against the same SSH server instance. The failure is specifically triggered bySshTests_TTYDisabled.SetUp()
callingPermitTTY(false)
, butReset()
not setting it back totrue
.this was noticed in #1704 (comment) .
To repro, you have to modify
InfrastructureFixture.InitializeAsync()
to always use the local container instead of setting one up with Testcontainers.Then run the following. This uses podman, but should in theory also work with docker.