What should be the "Standard License Header"

[joachimmetz]

as observed in #66 afflib.h indicates Distributed under the Berkeley 4-part license but has no explicit copyright statement

https://spdx.org/licenses/BSD-4-Clause.html only references the license, but does not define a "Standard License Header"

(for contrast https://spdx.org/licenses/GPL-3.0-only.html which does define a "Standard License Header")

This source recommends adding the copyright statement which I would gravitate towards as well.

[sshock]

I like the idea of using SPDX standard line in all files, e.g.:

SPDX-License-Identifier: BSD-4-Clause

BTW, I'm not seeing the Distributed under the Berkeley 4-part license in include/afflib/afflib.h yet, which must be an oversight, since the COPYING file includes it in the list of files covered by the license, and several other source and header files have it.

I think it's a good idea to add SPDX-License-Identifier: BSD-4-Clause to afflib.h and afflib_i.h, and replace any occurrence of Distributed under the Berkeley 4-part license (seen in many other files) with it.

But I'm not inclined to add a copyright statement to any files, as I would not know who to put in each one. Also, the afflib.h at least doesn't need it because it already has a copyright statement:

• Copyright (c) 2005-2006
• Simson L. Garfinkel and Basis Technology, Inc.

•  All rights reserved.
  

[joachimmetz]

Also, the afflib.h at least doesn't need it because it already has a copyright statement

Sorry my bad, I meant ./lib/s3_glue.cpp not afflib.h

But I'm not inclined to add a copyright statement to any files

Is up to you

as I would not know who to put in each one

This might help to extract the original author

$ git log -p --raw --no-merges ./lib/s3_glue.cpp
...
commit 75145009cc5380d884deda8c99e91c7faa38213f
Author: Simson Garfinkel <simsong@acm.org>
...
new file mode 100644
index 0000000..71adab5
--- /dev/null
...