Skip to content

Commit

Permalink
removed \dontrun{}
Browse files Browse the repository at this point in the history
  • Loading branch information
telkamp7 committed Nov 7, 2023
1 parent 15223a4 commit bd37038
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 13 deletions.
5 changes: 2 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
Version: 0.1.0
Date: 2023-11-03 10:00:15 UTC
SHA:
a44b5d932c77a32db3712a253e119a2b83e91037
Date: 2023-11-06 09:44:14 UTC
SHA: ca13b89b3b2a93813176088ef40374eba78aac7d
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ S3method(predict,aedseo)
S3method(summary,aedseo)
export("%>%")
export(aedseo)
export(autoplot)
export(fit_growth_rate)
export(tsd)
importFrom(ggplot2,autoplot)
Expand Down
7 changes: 5 additions & 2 deletions R/autoplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#' @aliases autoplot
#'
#' @examples
#' \dontrun{
#' # Create an example aedseo_tsd object
#' aedseo_tsd_object <- tsd(
#' observed = c(100, 120, 150, 180, 220, 270),
Expand Down Expand Up @@ -46,9 +45,13 @@
#'
#' # Create a ggplot visualization of growth rates with confidence intervals
#' autoplot(aedseo_object, linewidth = 1, alpha = 0.2)
#' }
#' @importFrom ggplot2 autoplot
#' @rdname autoplot
#' @export
autoplot <- function (object, ...) {

Check warning on line 51 in R/autoplot.R

View workflow job for this annotation

GitHub Actions / lint

file=R/autoplot.R,line=51,col=21,[function_left_parentheses_linter] Remove spaces before the left parenthesis in a function definition.
UseMethod("autoplot")
}
#' @rdname autoplot
#' @method autoplot aedseo_tsd
#' @export
autoplot.aedseo_tsd <- function(object, ...) {
Expand Down
6 changes: 2 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@ The package has been tested on multiple platforms and no errors or warnings were

## Reviewer Feedback

Thank you for the feedback, and we've addressed the issues mentioned:
We have addressed the feedback from the previous review. Specifically:

1. **References**: We've added references to the methods used in our package in the DESCRIPTION file in the required format: authors (year) <doi:...>. Note that this is a novel method for the detection of seasonal epidemic onsets and that there are currently no references available.

2. **Commented Code in Examples**: We've removed commented code lines in examples and have made sure that the examples can be executed without issues.
1. **Removal of \dontrun{}**: We have removed the `\dontrun{}` wrappers in the examples as we confirmed that the examples run in less than 5 seconds.

## Abbreviations

Expand Down
8 changes: 4 additions & 4 deletions man/autoplot.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bd37038

Please sign in to comment.