Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0 #1180

Merged
merged 25 commits into from
Oct 30, 2023
Merged

v1.1.0 #1180

merged 25 commits into from
Oct 30, 2023

Conversation

liorrutenberg
Copy link
Contributor

No description provided.

moshe-blox and others added 24 commits September 6, 2023 12:35
* Log File Options
* fix: jammed `indicesChange` channel

---------

Co-authored-by: y0sher <lyosher@gmail.com>
* Fix round distribution metrics

---------

Co-authored-by: moshe-blox <moshe@blox.io>
* implementation

* deprecate spec timer interface

* adjust round timeout func

* add TODO SIP comments

* add timeout for first round

* fix test

* add test

* adjust tests with custom time at slot func

* use beacon network interface in timer

* make all roles deterministic except proposer

* fix merge conflicts

* renaming + rearranging to simplify

* spec alignment

---------

Co-authored-by: moshe-blox <moshe@blox.io>
* Audits Directory

* add to README
* remove share & SP data with share pubkey fix

* move tx related logic to event handler + tests
* fix generate operator keys command

* add #nosec G304 for file reading

* extract I/O operations to seperate functions

* switch logic to rsa package functions

* clean code and add public key to keystore
* improved ValidatorRemoved tests. Fixed sol contract

* improved OperatorRemoved test

* improved ClusterLiquidated & ClusterReactivated tests

* minor fixes + do / undo tests

* minor fixes + do / undo tests (#1132)

* tests: added ValidatorRegistered test case with different owner
* Fix issues in tests

* Fix linter

* Fix TestSSVMapping

* Attempt to fix fetchLogsInBatches

* Revert "Attempt to fix fetchLogsInBatches"

This reverts commit 96006c2.

* Attempt to fix fetchLogsInBatches

* Revert "Attempt to fix fetchLogsInBatches"

This reverts commit 5a3d9de.

* Revert "Fix TestSSVMapping"

This reverts commit c3263c1.

* Revert "Fix linter"

This reverts commit 8f72bb2.

* Revert "Fix issues in tests"

This reverts commit 0720abb.

* Change batch verifier params

* Disable signature check

* Revert "Disable signature check"

This reverts commit 311c722.

* Batch size 10

* Disable signature check

* Use BLSU for signature verification

* BLSU aggregate

* Disable partial signature check

* Disable consensus signature check

* Fix linter

* Revert "BLSU aggregate"

* Revert "Use BLSU for signature verification"

This reverts commit 6d4c15f.

* AggregateVerify for partial signature

* Simplify duplicated signer check

* Fix error text

* Fix check order

* Fix issues in tests

* Revert "Fix issues in tests"

This reverts commit b40355c.

* Move deployment to 5-8

* Fix some tests

* Fix data race

* Revert "Fix data race"

This reverts commit e3596a2.

* Attempt to fix data race

* Revert "Attempt to fix data race"

This reverts commit 38cce5f.

* Attempt to fix data race [2]

* Fix spec tests

* Fix a data race

* Fix a data race in tests bootstrapper

* Fix differ config

* Change message size metric to histogram

* Fix some tests

* Fix linter

* Fix unit tests

* More tests

* Improve tests

* More tests

* More tests [2]

* More tests [3]

* Fix incorrect usage of errors.As in tests

* More tests

* Deploy to 1-4 instead of 5-8

* Add logs with message processing duration

* Fix message validation duration buckets

* Add logs/metrics with signature check duration

* Disable duration logs

* Use single verification

* Revert "Use single verification"

This reverts commit cae01d2.

* More tests

* Fix max duties check

* More tests

* Fix duty count validation

* More tests

* More tests

* Fix duty count bug

* Add message queue metrics

* Fix a typo

* Revert "Fix message validation duration buckets"

This reverts commit 269340b.

* Fix validation duration buckets

* Cache serialized signature

* Fix variable name

* Revert "Fix variable name"

This reverts commit 15345a2.

* Revert "Cache serialized signature"

This reverts commit 20245e2.

* Queue len/cap as gauge

* Add message validation dashboard

* Enable signature checks

* Disable signature verification for non-committee non-decided

* Fix bug with committee check

* Verify partial signatures only if in committee

* Fix check

* Simplify code

* Add metrics if in committee

* Fix value of InvalidMessageDeliveriesWeight

* Deploy to 5-8 instead of 1-4

* Implement duty fetcher for message validation

* Get rid of optsTemplate in validatorsMap

* Make validators map exported and pass it to duty fetcher

* Fix panic due to context passing

* Simplify saving validators

* Debug panic

* Revert "Debug panic"

This reverts commit 76c273f.

* Revert "Simplify saving validators"

This reverts commit b24d704.

* Revert "Fix panic due to context passing"

This reverts commit 44b47f3.

* Revert "Make validators map exported and pass it to duty fetcher"

This reverts commit 82ee64d.

* Revert "Get rid of optsTemplate in validatorsMap"

This reverts commit 20cc1b7.

* Revert "Implement duty fetcher for message validation"

This reverts commit dabc10a.

* Implement duty fetcher for message validation

* Fix context panic

* Fix signature in message validation tests

* Get rid of optsTemplate in validatorsMap

* Fix condition

* Make validators map exported and pass it to duty fetcher

* Revert "Make validators map exported and pass it to duty fetcher"

This reverts commit 65729f3.

* Fix logic of validating beacon duty, add test

* Make validators map exported and pass it to duty fetcher

* Start duty fetcher

* Revert "Start duty fetcher"

This reverts commit cf3f51f.

* Revert "Make validators map exported and pass it to duty fetcher"

This reverts commit 563143c.

* Start duty fetcher

* Attempt to make validators map exported

* Move ActiveValidatorIndices to ValidatorsMap

* Use logger in DutyFetcher

* Pass validators map from node to validator controller

* Enable duty fetcher

* Revert "Enable duty fetcher"

This reverts commit 3648788.

* Extract validator creation logic from validators map

* Simplify creating validator

* Delete redundant comment

* Fix linter

* Init and start duty fetcher but don't pass to message validator

* Fix fetcher bug

* Use fetcher

* go mod tidy

* Duty fetcher tests

* Remove redundant file

* Fix imports

* Disable deployment

* Enable signature check for all messages

* Fix issues after merging

* Fix .gitlab-ci.yml

* Enable message validation in sync

* Revert "Enable signature check for all messages"

This reverts commit 8c692b9.

* Deploy to 5-8

* Try blst verify

* Try to fix error

* Enable signature check for all messages

* Revert "Enable signature check for all messages"

This reverts commit b0849c8.

* Revert "Try to fix error"

This reverts commit 0c9d35f.

* Revert "Try blst verify"

This reverts commit 38bbe35.

* Flag for signature verification in message validation

* Optimization for SingleVerifyByOperators

* Remove outdated comment

* Delete unused errors

* Try to fix bug with ErrTooManyDutiesPerEpoch

* Code review requests

* Try to fix bug with ErrTooManyDuties

* Delete ErrUnexpectedMessageOrder

* Delete ErrDecidedSignersSequence

* Try RSA verification instead of BLS in most places

* Enable signature check in message validation

* Revert "Enable signature check in message validation"

This reverts commit ef1a05c.

* Revert "Try RSA verification instead of BLS in most places"

This reverts commit 0e16b11.

* Don't check for signature check flag in protocol

* Revert "Don't check for signature check flag in protocol"

This reverts commit 9f46933.

* Add logs for config

* Debugging

* Debugging [2]

* Debugging [3]

* Debugging [4]

* Debugging [5]

* Debugging [6]

* Add passing signature check for non-committee validators

* Revert "Debugging [6]"

This reverts commit d4d99d0.

* Revert "Debugging [5]"

This reverts commit 425f30b.

* Revert "Debugging [4]"

This reverts commit a5ade77.

* Revert "Debugging [3]"

This reverts commit 97398bc.

* Revert "Debugging [2]"

This reverts commit 91b4507.

* Revert "Debugging"

This reverts commit adb769f.

* Revert "Add logs for config"

This reverts commit f016ace.

* Try RSA verification instead of BLS in most places

* Enable signature check in message validation

* Revert "Try RSA verification instead of BLS in most places"

This reverts commit 29a196e.

* Revert "Enable signature check in message validation"

This reverts commit 080d876.

* Try to fix bug with ErrTooManyDutiesPerEpoch

* fetch metadata for all validators

* LA Audit (#1136)

* Audits Directory

* add to README

* Update dashboard

* Revert "fetch metadata for all validators"

This reverts commit 68df177.

* fetch metadata for all validators

* Fix differ

* Attempt to fix duty fetcher

* Fix panic

* Fix duty fetcher tests

* Fix event handler tests

* Add ErrNoShareMetadata

* Add test for ErrNoShareMetadata

* Revert differ change

* Get rid of type assertions/switches

* Extract duty storage from duty scheduler

* Fetch all duties, process only committee duties for proposer

* Fetch all duties, process only committee duties for sync committee

* Deploy to 1-4 as well

* Fix potential nil ptr dereference

* Forbid consensus message with validator registration role

* Revert message queue changes

* Check message counts for partial signature messages

* Add role and round to metrics

* Update Grafana

* Update Grafana

* WIP on rejection/banning test

* rename `dutystorage` to `dutystore`

* refactor

* refator MessageValidator to an interface

* update Grafana dashboard

* Don't start validator registration duty if not attesting

* Test improvements from Andrew

* Fix docker build

* Update bind-tools

* Cleanup

* rename `CheckSignature` to `VerifySignatures`

* Enable nil config checks

* Create qbft config in message validation

* Revert "Enable nil config checks"

This reverts commit 5b547d9.

* Fix panic

* Fix panic [2]

* Add signature check option

* Add godoc

* Disable deployment

* Reset epoch/period for previous one instead of current one

* Revert "Disable deployment"

This reverts commit cb585d3.

* Fix duplication bug

* keep old duties

* Revert "Reset epoch/period for previous one instead of current one"

This reverts commit 0a803a0.

* Disable deployment

* Revert "Disable deployment"

This reverts commit cfd23f8.

* Cleanup a TODO

* Disable deployment

* Revert "Disable deployment"

This reverts commit cc0ab52.

* Pass context instead of logger to message router

* Add a test for GetSlotEndTime

* performance optimization

* change YAML representation of msg validation sig flag & add log

* extract batch verifier to separate file

* approve spec alignment

* fix test

* Delete debug.log

* Disable deployment

* Disable batch verifier

* Fix compilation

* Delete batch verifier

* Simplify GetSignerState

* Add a note about NTP

* go mod tidy

---------

Co-authored-by: moshe-blox <moshe@blox.io>
Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com>
* improved ValidatorRemoved tests. Fixed sol contract

* improved OperatorRemoved test

* improved ClusterLiquidated & ClusterReactivated tests

* minor fixes + do / undo tests

* tests: refactored event_handler. added exporting private methods

* e2e test: added happy flow for sync history

* e2e testing framework init

* tests: added SyncHistory / SyncOngoing working tests

* tests: added comment

* tests: simplified, added more generating functions

* tests: added ctrl chan for stopping the sync on going tests

* tests: splitted by separted files

* tests: added unified interface

* tests: added val removed event test

* tests: added common refactoring

* tests: fixed setup local test env for e2e

* tests: fixed linter errors

* tests: Fixed mocked validator ctrl usage. fixed tests. Added cluster liquidation event test

* tests: Added cluster reactivated event handling test

* tests: Added missing happy flow tests

* tests: removed require usage in setuptest env functions

* tests: fixed %v => %w for errors

* tests: added httpSrv close on error in setupEnv

* tests: refactored error handling in testEnv setup

* tests: replace multiple error hundling with one defer shutdown call of testEnv

* tests: added followDistance to e2e testEnv. Added minor fixes accoriding to the review

* tests: changed unclear lines. Refactored default follow distance func

* tests: simplified testEnv setup

* tests: code style fixes, renaming for better readability, minor text fixes

* tests: code style fixes. Removing extra variables

* tests: formatted imports

* tests: grammar fixes requested from PR review
* feat: new slot_ticker prototype

* feat: replace old slot ticker with new one

* chore: fix ticker tests

* chore: review changes

* resovled another review comments

* add review changes

* update after review

* add more strict check on skipping test

* deploy to 5--8 for testing

* fix passing worng args

* add metrics for slot delay

* change to histrogram

* triger ci

* update Grafana dashboard

* add late duty log info

* add log to warn of late duty execution

* Revert "add late duty log info"

This reverts commit 8cd5442.

* Revert "deploy to 5--8 for testing"

This reverts commit e862fea.

---------

Co-authored-by: Matus Kysel <matus@Matuss-MacBook-Air.local>
Co-authored-by: moshe-blox <moshe@blox.io>
* update ssv-spec to #drop-blinded-block-rejection

* refactors

* update spec JSONs

* update ssv-spec to main branch

* generate mocks

* spec alignments

* refactors: remove syncing methods

* lint fixes

* more alignments & differ approvals

* ignore voluntary exit tests

* log skipped tests

* state comparison wip

* update spec to 0.3.3

* go mod tidy

* qbft spectest fixes

* undo temporary test

* more spec test fixes

* fix more spec tests

* fixes for new linter version

* approve spec diffs

* removed unused method

* remove unused func
* Squashed commit of the following:

commit 315634bfa500070de8d201066f5ec6ced5ebbb02
Merge: 17d2cbd 37df406
Author: moshe-blox <moshe@blox.io>
Date:   Tue Oct 24 12:52:53 2023 +0300

    Merge branch 'holesky-stage-config' into holesky-stage-configuration

commit 17d2cbd
Author: moshe-blox <moshe@blox.io>
Date:   Tue Oct 24 12:49:13 2023 +0300

    deploy to 5--8

commit cdc6da2
Author: moshe-blox <moshe@blox.io>
Date:   Tue Oct 24 12:23:54 2023 +0300

    remove unused func

commit 37df406
Author: Lior Rutenberg <liorr@blox.io>
Date:   Sun Oct 22 19:34:50 2023 +0300

    update ekm version to holskey supported pr

commit 367ff64
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 16:34:51 2023 +0300

    removed unused method

commit 094f7c4
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 16:11:05 2023 +0300

    approve spec diffs

commit 1eb377f
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 16:09:56 2023 +0300

    fixes for new linter version

commit c17dd60
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 15:34:39 2023 +0300

    fix more spec tests

commit ad965b0
Author: Lior Rutenberg <liorr@blox.io>
Date:   Sun Oct 22 14:28:58 2023 +0300

    updated supported network

commit c1449e4
Author: Lior Rutenberg <liorr@blox.io>
Date:   Sun Oct 22 14:23:51 2023 +0300

    updated k8 files config

commit 3ba3c3d
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 14:13:33 2023 +0300

    more spec test fixes

commit f36ad22
Merge: 97b04f5 1fbe548
Author: Lior Rutenberg <liorr@blox.io>
Date:   Sun Oct 22 14:01:57 2023 +0300

    Merge branch 'update-spec' into holesky-stage-config

commit 1fbe548
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 13:25:26 2023 +0300

    undo temporary test

commit 80ed66d
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 13:25:00 2023 +0300

    qbft spectest fixes

commit ff61279
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 13:03:22 2023 +0300

    go mod tidy

commit bb3bad1
Author: moshe-blox <moshe@blox.io>
Date:   Sun Oct 22 13:02:17 2023 +0300

    update spec to 0.3.3

commit ea4af6b
Author: moshe-blox <moshe@blox.io>
Date:   Fri Oct 20 17:28:35 2023 +0300

    state comparison wip

commit 8b8e0fc
Author: moshe-blox <moshe@blox.io>
Date:   Thu Oct 19 13:18:38 2023 +0300

    log skipped tests

commit d5aae93
Author: moshe-blox <moshe@blox.io>
Date:   Thu Oct 19 13:17:09 2023 +0300

    ignore voluntary exit tests

commit e308f56
Author: moshe-blox <moshe@blox.io>
Date:   Thu Oct 19 13:04:09 2023 +0300

    more alignments & differ approvals

commit bb10c46
Author: moshe-blox <moshe@blox.io>
Date:   Thu Oct 19 12:52:48 2023 +0300

    lint fixes

commit edb9f65
Author: moshe-blox <moshe@blox.io>
Date:   Thu Oct 19 12:38:42 2023 +0300

    refactors: remove syncing methods

commit a237d84
Author: moshe-blox <moshe@blox.io>
Date:   Wed Oct 18 17:19:09 2023 +0300

    spec alignments

commit bc79993
Author: moshe-blox <moshe@blox.io>
Date:   Wed Oct 18 16:59:13 2023 +0300

    generate mocks

commit 083f164
Merge: e436f3b 090b237
Author: moshe-blox <moshe@blox.io>
Date:   Wed Oct 18 16:57:43 2023 +0300

    Merge branch 'stage' into update-spec

commit 97b04f5
Author: stoyan.peev <stoyan.peev@gotoadmins.com>
Date:   Wed Oct 18 16:10:48 2023 +0300

    Deploy Holesky to ssv-nodes 1-4

commit f27978d
Author: stoyan.peev <stoyan.peev@gotoadmins.com>
Date:   Wed Oct 18 14:23:44 2023 +0300

    Added enr for Holesky boot node

commit 8a73e8a
Author: Lior Rutenberg <liorr@blox.io>
Date:   Wed Oct 18 11:24:33 2023 +0300

    added holesky support

commit e436f3b
Author: moshe-blox <moshe@blox.io>
Date:   Wed Sep 20 12:17:16 2023 +0300

    update ssv-spec to main branch

commit 58ff263
Merge: f2d01ba b2a8ec4
Author: moshe-blox <moshe@blox.io>
Date:   Wed Sep 20 12:14:19 2023 +0300

    Merge branch 'stage' into update-spec

commit f2d01ba
Author: moshe-blox <moshe@blox.io>
Date:   Sun Aug 20 16:27:34 2023 +0300

    update spec JSONs

commit 26e9929
Author: moshe-blox <moshe@blox.io>
Date:   Sun Aug 20 16:02:34 2023 +0300

    refactors

commit fa3571f
Author: moshe-blox <moshe@blox.io>
Date:   Sun Aug 20 15:57:26 2023 +0300

    update ssv-spec to #drop-blinded-block-rejection

* revert gitlab ci

* gofmt

---------

Co-authored-by: moshe-blox <moshe@blox.io>
* merge between hetzer and stage deployments

* remove andrew network

* add only stage to the hetzner
* Updated Hetzner ci/cd
---------

Co-authored-by: stoyan.peev <stoyan.peev@gotoadmins.com>
* holesky exporter deployment files

* migrate holesky exporetr to hetzner
* Updated gitlab-ci

* Updated permissions

* Updated env

* Updated ci/cd

* Updated gitlab-ci

* Updated gitlab-ci

* Updated holesky exporter

* Updated holesky exporter

---------

Co-authored-by: stoyan.peev <stoyan.peev@gotoadmins.com>
---------

Co-authored-by: stoyan.peev <stoyan.peev@gotoadmins.com>
Co-authored-by: systemblox <40427708+systemblox@users.noreply.github.com>
* add logs and fix validator registrations.

* chore: deploy BUILDER_PROPOSALS to mainnet

---------

Co-authored-by: moshe-blox <moshe@blox.io>
@moshe-blox moshe-blox closed this Oct 30, 2023
@liorrutenberg liorrutenberg reopened this Oct 30, 2023
@ssvlabs ssvlabs deleted a comment from moshe-blox Oct 30, 2023
@liorrutenberg liorrutenberg changed the title v1.0.1 v1.1.0 Oct 30, 2023
@liorrutenberg liorrutenberg merged commit 7e3a2b3 into main Oct 30, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants