Skip to content

[!14775] Print fully qualified unit names in name mismatch #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[!14775] Print fully qualified unit names in name mismatch #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions compiler/GHC/Iface/Errors/Ppr.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,16 +336,17 @@ hiModuleNameMismatchWarn requested_mod read_mod
]
]
| otherwise =
-- ToDo: This will fail to have enough qualification when the package IDs
-- are the same
-- Display fully qualified unit names by enabling ppr-debug. Otherwise we
-- may not have enough qualification and the printed names could look exactly
-- the same.
updSDocContext (\ctx -> ctx { sdocPprDebug = True}) $
withPprStyle (mkUserStyle alwaysQualify AllTheWay) $
-- we want the Modules below to be qualified with package names,
-- so reset the NamePprCtx setting.
hsep [ text "Something is amiss; requested module "
, ppr requested_mod
, text "differs from name found in the interface file"
, ppr read_mod
, parens (text "if these names look the same, try again with -dppr-debug")
]

dynamicHashMismatchError :: Module -> ModLocation -> SDoc
Expand Down