Skip to content

[!14788] testsuite: clarify Windows/Darwin locale rationale for skipping T6037… #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[!14788] testsuite: clarify Windows/Darwin locale rationale for skipping T6037… #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions testsuite/tests/driver/all.T
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,24 +179,23 @@ test('T7060', [], makefile_test, [])
test('T7130', normal, compile_fail, ['-fflul-laziness'])
test('T7563', when(unregisterised(), skip), makefile_test, [])
test('T6037',
# The testsuite doesn't know how to set a non-Unicode locale on Windows or MacOS < Sonoma.
# Because in previous version of MacOS the test is still broken, we mark it as fragile.
# Requires forcing a 7-bit/ASCII-only locale.
# - On Windows (mingw32) the testsuite can't reliably set a non-Unicode C locale -> expect_fail.
# - On modern Darwin there are no pure ASCII locales available -> skip.
[when(opsys('mingw32'), expect_fail),
when(opsys('darwin'), fragile(24161))
when(opsys('darwin'), skip)
],
makefile_test, [])
test('T2507',
# The testsuite doesn't know how to set a non-Unicode locale on Windows or MacOS < Sonoma
# Because in previous version of MacOS the test is still broken, we mark it as fragile.
# Same locale assumptions as T6037 (ASCII-only needed, unavailable on Darwin; untestable on Windows).
[when(opsys('mingw32'), expect_fail),
when(opsys('darwin'), fragile(24161))
when(opsys('darwin'), skip)
],
makefile_test, [])
test('T8959a',
# The testsuite doesn't know how to set a non-Unicode locale on Windows or MacOS < Sonoma
# Because in previous version of MacOS the test is still broken, we mark it as fragile.
# Same locale assumptions as T6037 (ASCII-only needed, unavailable on Darwin; untestable on Windows).
[when(opsys('mingw32'), expect_fail),
when(opsys('darwin'), fragile(24161))
when(opsys('darwin'), skip)
],
makefile_test, [])

Expand Down