Skip to content

[!14789] Skip broken tests on macOS (due to leading underscore not handled pro… #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[!14789] Skip broken tests on macOS (due to leading underscore not handled pro… #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions testsuite/tests/rts/linker/T11223/all.T
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ test('T11223_simple_duplicate',

test('T11223_simple_duplicate_lib',
[extra_files(['bar.c', 'foo.c', 'foo.hs']),
when(ghc_dynamic(), skip), normalise_errmsg_fun(normalise_duplicate_errmsg),
when(ghc_dynamic(), skip),
# Darwin/Mach-O reports external C symbols with a leading underscore (e.g. _a, _c)
# which our expected stderr (shared with ELF platforms) does not account for.
# Rather than broaden normalisation here, skip on darwin for now.
when(opsys('darwin'), skip),
normalise_errmsg_fun(normalise_duplicate_errmsg),
req_c],
makefile_test, ['t_11223_simple_duplicate_lib'])

Expand All @@ -57,7 +62,10 @@ test('T11223_link_order_b_a_succeed',

test('T11223_link_order_a_b_2_fail',
[extra_files(['bar.c', 'foo.c', 'foo3.hs']),
when(ghc_dynamic(), skip), normalise_errmsg_fun(normalise_duplicate_errmsg),
when(ghc_dynamic(), skip),
# See note above about Mach-O leading underscores; skip on darwin.
when(opsys('darwin'), skip),
normalise_errmsg_fun(normalise_duplicate_errmsg),
req_c],
makefile_test, ['t_11223_link_order_a_b_2_fail'])

Expand Down