-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a vector dimension #10
Conversation
ca135ba
to
811fc66
Compare
Is it still a vector cube if it has IDs as labels of the vector dimension? For all uses in processes, such a cube would be just a normal What is the benefit of supporting both GeoJSON and WKT? I'd go with just GeoJSON. |
Yes, the metadata just gives an overview of what is inside. It doesn't necessarily reflect the full internal structure.
We are in STAC here, there are no processes involved here, but the difference is for example that you have an extent in x and y direction at the same time (see different fields in the dimension). And in general, it's just a tad different from the others and that's the same for all the other types exposed here. Each of them could basically also described as "Additional Dimension", but still we have some specifics here and there added so that it seems to make sense to distinguish them.
GeoJSON is WGS84 while in WKT you can give the coordinates in the reference system given for the dimension while on the other hand GeoJSON features could also include properties, which is not possible in WKT (afaik). So depending on the use case you may want to choose the best fit. In the end, I just wasn't sure what people (also outside of openEO as this is the STAC extension) would prefer. |
# Conflicts: # CHANGELOG.md
Should we add a vector type field to indicate whether e.g. all geometries are points? |
yes |
# Conflicts: # CHANGELOG.md
Added This is ready for final review! |
@soxofaan @mkadunc @aljacob @clausmichele @jdries @dthiex @LukeWeidenwalker @pierocampa This is also ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed yesterday, looks all good to me now, thanks for the hard work!!
nice work! |
A WIP draft for a new dimension of type vector.