Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a vector dimension #10

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Add a vector dimension #10

merged 9 commits into from
Jan 18, 2023

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Feb 23, 2022

A WIP draft for a new dimension of type vector.

@m-mohr m-mohr added this to the 2.1.0 milestone Feb 23, 2022
@m-mohr m-mohr self-assigned this Feb 23, 2022
@m-mohr m-mohr force-pushed the vector-cubes branch 5 times, most recently from ca135ba to 811fc66 Compare February 24, 2022 15:15
@m-mohr m-mohr marked this pull request as ready for review March 1, 2022 14:22
@mkadunc
Copy link

mkadunc commented Mar 10, 2022

The other question which representations we allow in metadata. Right now it supports:

  • GeoJSON (full set right now, so includes Features, but we may want to remove FeatureCollections though, see above)
  • WKT for Geometries
  • IDs

Is it still a vector cube if it has IDs as labels of the vector dimension? For all uses in processes, such a cube would be just a normal data-cube; what use is calling such a dimension vector?

What is the benefit of supporting both GeoJSON and WKT? I'd go with just GeoJSON.

@m-mohr
Copy link
Contributor Author

m-mohr commented Mar 10, 2022

Is it still a vector cube if it has IDs as labels of the vector dimension?

Yes, the metadata just gives an overview of what is inside. It doesn't necessarily reflect the full internal structure.

For all uses in processes, such a cube would be just a normal data-cube; what use is calling such a dimension vector?

We are in STAC here, there are no processes involved here, but the difference is for example that you have an extent in x and y direction at the same time (see different fields in the dimension). And in general, it's just a tad different from the others and that's the same for all the other types exposed here. Each of them could basically also described as "Additional Dimension", but still we have some specifics here and there added so that it seems to make sense to distinguish them.

What is the benefit of supporting both GeoJSON and WKT? I'd go with just GeoJSON.

GeoJSON is WGS84 while in WKT you can give the coordinates in the reference system given for the dimension while on the other hand GeoJSON features could also include properties, which is not possible in WKT (afaik). So depending on the use case you may want to choose the best fit. In the end, I just wasn't sure what people (also outside of openEO as this is the STAC extension) would prefer.

@m-mohr
Copy link
Contributor Author

m-mohr commented Sep 9, 2022

Should we add a vector type field to indicate whether e.g. all geometries are points?

@mkadunc
Copy link

mkadunc commented Sep 17, 2022

Should we add a vector type field to indicate whether e.g. all geometries are points?

yes

@m-mohr
Copy link
Contributor Author

m-mohr commented Nov 7, 2022

Added geometry_types and axes as new fields.

This is ready for final review!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@m-mohr m-mohr requested a review from edzer January 17, 2023 18:22
@m-mohr
Copy link
Contributor Author

m-mohr commented Jan 17, 2023

@soxofaan @mkadunc @aljacob @clausmichele @jdries @dthiex @LukeWeidenwalker @pierocampa This is also ready for final review.

Copy link

@aljacob aljacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed yesterday, looks all good to me now, thanks for the hard work!!

@jdries
Copy link

jdries commented Jan 18, 2023

nice work!

examples/vector.json Outdated Show resolved Hide resolved
@m-mohr m-mohr merged commit 17d18aa into main Jan 18, 2023
@m-mohr m-mohr deleted the vector-cubes branch January 18, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants