Make sure that only arguments that are properties are cheked

[drnextgis]

Fixes #218

[drnextgis]

I moved the code to a different location and added a loop to iterate through all properties, ensuring all of them are included in the queryables. Previously, the code was placed incorrectly in the loop which was only meant to detect the wrapper. Furthermore, I made it explicit in the code that the properties id, datetime, end_datetime, and collection are always considered queryable.

[bitner]

Good Catch!

Hmmm. Actually, I think that we can do this even higher up in the stack in a way that can fail on the first call of cql2_query and not need to wait until we go down the recursive tree of the query. I'll suggest something in just a minute...

[bitner]

@drnextgis I think if we put something like this:

    IF NOT extra_props THEN
        FOR prop IN 
            SELECT DISTINCT p->>0 
            FROM jsonb_path_query(j, 'STRICT $..property')
            WHERE p->>0 NOT IN ('id', 'datetime', 'end_datetime', 'collection')
        LOOP
            IF (queryable(prop)).nulled_wrapper IS NULL THEN
                RAISE EXCEPTION 'Term % is not found in queryables.', arg->>'property';
            END IF;
        END LOOP;
    END IF;

at the very top of the cql2_query (probably right after the RAISE NOTICE 'CQL2_QUERY: %', j; it should find any property nested anywhere in the filter on the first call to cql2_query rather than when things have gone down the nesting iterations. I think this will be more resistant to any of the different implementations for spatial, array, and temporal operators.

[drnextgis]

@bitner thank you! I've updated the PR.

[bitner]

Looks good!