Skip to content

Conversation

jsignell
Copy link
Member

Related Issue(s):

Description:

Went down a rabbit hole and ended up doing a release of xpystac to support newer versions of zarr and kerchunk

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (918c629) to head (fbbc558).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1573   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          55       55           
  Lines        8374     8374           
  Branches      965      965           
=======================================
  Hits         7736     7736           
  Misses        453      453           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gadomski gadomski self-requested a review August 20, 2025 17:52
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about deps, otherwise lgtm

"id": "11dddb09-6313-4822-90ba-26eb6e5c143b",
"metadata": {},
"outputs": [],
"source": [
"!pip install adlfs dask 'fsspec[http]' planetary_computer --quiet\n",
"!pip install stackstac xarray xpystac zarr --quiet"
"!pip install odc-stac rioxarray xarray xpystac zarr --quiet"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding these to pyproject.toml under the docs group as well? I have the uv environment on my machine so these pip install calls fail b/c there's no pip:

diff --git a/pyproject.toml b/pyproject.toml
index 51f7bcbc..570397c9 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -58,18 +58,24 @@ dev = [
     "virtualenv>=20.26.6",
 ]
 docs = [
+    "adlfs>=2024.12.0",
     "boto3>=1.35.39",
     "ipython>=8.28.0",
     "jinja2>=3.1.4",
     "jupyter>=1.1.1",
     "nbsphinx>=0.9.5",
+    "odc-stac>=0.4.0",
+    "planetary-computer>=1.0.0",
     "pydata-sphinx-theme>=0.15.4",
     "rasterio>=1.4.1",
+    "rioxarray>=0.19.0",
     "shapely>=2.0.6",
     "sphinx>=8.1.1",
     "sphinx-autobuild>=2024.10.3",
     "sphinx-design>=0.6.1",
     "sphinxcontrib-fulltoc>=1.2.0",
+    "xpystac>=0.2.0",
+    "zarr>=2.18.3",
 ]
 
 [project.urls]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeaaaahhh I didn't really do the pip step locally either. Adding them to the docs group is fine by me.

@jsignell jsignell requested a review from gadomski August 21, 2025 20:05
@jsignell jsignell added this pull request to the merge queue Aug 21, 2025
Merged via the queue into stac-utils:main with commit fd50d9b Aug 21, 2025
19 checks passed
@jsignell jsignell deleted the tutorial-fix branch August 21, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read STAC Tutorial Broken w/ Current Library Versions
2 participants