-
Notifications
You must be signed in to change notification settings - Fork 124
Update how to read tutorial #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 55 55
Lines 8374 8374
Branches 965 965
=======================================
Hits 7736 7736
Misses 453 453
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note about deps, otherwise lgtm
"id": "11dddb09-6313-4822-90ba-26eb6e5c143b", | ||
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"!pip install adlfs dask 'fsspec[http]' planetary_computer --quiet\n", | ||
"!pip install stackstac xarray xpystac zarr --quiet" | ||
"!pip install odc-stac rioxarray xarray xpystac zarr --quiet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding these to pyproject.toml
under the docs
group as well? I have the uv environment on my machine so these pip install
calls fail b/c there's no pip:
diff --git a/pyproject.toml b/pyproject.toml
index 51f7bcbc..570397c9 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -58,18 +58,24 @@ dev = [
"virtualenv>=20.26.6",
]
docs = [
+ "adlfs>=2024.12.0",
"boto3>=1.35.39",
"ipython>=8.28.0",
"jinja2>=3.1.4",
"jupyter>=1.1.1",
"nbsphinx>=0.9.5",
+ "odc-stac>=0.4.0",
+ "planetary-computer>=1.0.0",
"pydata-sphinx-theme>=0.15.4",
"rasterio>=1.4.1",
+ "rioxarray>=0.19.0",
"shapely>=2.0.6",
"sphinx>=8.1.1",
"sphinx-autobuild>=2024.10.3",
"sphinx-design>=0.6.1",
"sphinxcontrib-fulltoc>=1.2.0",
+ "xpystac>=0.2.0",
+ "zarr>=2.18.3",
]
[project.urls]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeaaaahhh I didn't really do the pip step locally either. Adding them to the docs group is fine by me.
Related Issue(s):
Description:
Went down a rabbit hole and ended up doing a release of xpystac to support newer versions of zarr and kerchunk
PR Checklist:
pre-commit run --all-files
)pytest
)