-
Notifications
You must be signed in to change notification settings - Fork 31
Fields extension implementation for collections/{collection}/items #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fields extension implementation for collections/{collection}/items #436
Conversation
Hi @z-mrozu. Really nice work here. I was working on something similar - adding sorting (and query) to the item collection route - while you pushed this pr. I will merge mine and then we can merge yours. It may need a few minor changes. |
…ension # Conflicts: # CHANGELOG.md # stac_fastapi/core/stac_fastapi/core/core.py
stac_fastapi/tests/conftest.py
Outdated
|
||
fields_extension = FieldsExtension() | ||
fields_extension.conformance_classes.append(FieldsConformanceClasses.ITEMS) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need to add anything to conftest.py, because everything we need should be added by importing app_config. We might want to add the conformance class to the two app.py files though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CHANGELOG.md
Outdated
- `STAC_INDEX_ASSETS` environment variable to allow asset serialization to be configurable. [#433](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/433) | ||
- Added the `ENV_MAX_LIMIT` environment variable to SFEOS, allowing overriding of the `MAX_LIMIT`, which controls the `?limit` parameter for returned items and STAC collections. [#434](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/434) | ||
- Sort, Query, and Filter extension and functionality to the item collection route. [#437](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/437) | ||
- Added Fields Extension implementation for the `/collections/{collection_id}/aggregations` endpoint. [#436](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/436) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be the: /collections/{collection_id}/items
endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good catch, fixed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here @z-mrozu
…tac-utils#436) **Description:** This PR implements the [Fields extension](https://github.com/stac-api-extensions/fields) for the /collections/{collection}/items endpoint similarly to how it's implemented for the /search endpoint. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: jonhealy1 <jonathan.d.healy@gmail.com>
…tac-utils#436) **Description:** This PR implements the [Fields extension](https://github.com/stac-api-extensions/fields) for the /collections/{collection}/items endpoint similarly to how it's implemented for the /search endpoint. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: jonhealy1 <jonathan.d.healy@gmail.com>
Description:
This PR implements the Fields extension for the /collections/{collection}/items endpoint similarly to how it's implemented for the /search endpoint.
PR Checklist:
pre-commit run --all-files
)make test
)