Skip to content

Conversation

z-mrozu
Copy link
Contributor

@z-mrozu z-mrozu commented Sep 11, 2025

Description:
This PR implements the Fields extension for the /collections/{collection}/items endpoint similarly to how it's implemented for the /search endpoint.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1
Copy link
Collaborator

jonhealy1 commented Sep 12, 2025

Hi @z-mrozu. Really nice work here. I was working on something similar - adding sorting (and query) to the item collection route - while you pushed this pr. I will merge mine and then we can merge yours. It may need a few minor changes.


fields_extension = FieldsExtension()
fields_extension.conformance_classes.append(FieldsConformanceClasses.ITEMS)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to add anything to conftest.py, because everything we need should be added by importing app_config. We might want to add the conformance class to the two app.py files though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CHANGELOG.md Outdated
- `STAC_INDEX_ASSETS` environment variable to allow asset serialization to be configurable. [#433](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/433)
- Added the `ENV_MAX_LIMIT` environment variable to SFEOS, allowing overriding of the `MAX_LIMIT`, which controls the `?limit` parameter for returned items and STAC collections. [#434](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/434)
- Sort, Query, and Filter extension and functionality to the item collection route. [#437](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/437)
- Added Fields Extension implementation for the `/collections/{collection_id}/aggregations` endpoint. [#436](https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/pull/436)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the: /collections/{collection_id}/items endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch, fixed that

@jonhealy1 jonhealy1 self-requested a review September 16, 2025 08:15
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @z-mrozu

@jonhealy1 jonhealy1 merged commit d53de6e into stac-utils:main Sep 16, 2025
15 checks passed
YuriZmytrakov pushed a commit to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch that referenced this pull request Sep 23, 2025
…tac-utils#436)

**Description:**
This PR implements the [Fields
extension](https://github.com/stac-api-extensions/fields) for the
/collections/{collection}/items endpoint similarly to how it's
implemented for the /search endpoint.

**PR Checklist:**

- [x] Code is formatted and linted (run `pre-commit run --all-files`)
- [x] Tests pass (run `make test`)
- [ ] Documentation has been updated to reflect changes, if applicable
- [x] Changes are added to the changelog

---------

Co-authored-by: jonhealy1 <jonathan.d.healy@gmail.com>
YuriZmytrakov pushed a commit to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch that referenced this pull request Sep 23, 2025
…tac-utils#436)

**Description:**
This PR implements the [Fields
extension](https://github.com/stac-api-extensions/fields) for the
/collections/{collection}/items endpoint similarly to how it's
implemented for the /search endpoint.

**PR Checklist:**

- [x] Code is formatted and linted (run `pre-commit run --all-files`)
- [x] Tests pass (run `make test`)
- [ ] Documentation has been updated to reflect changes, if applicable
- [x] Changes are added to the changelog

---------

Co-authored-by: jonhealy1 <jonathan.d.healy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants