Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'type' to LandingPage; fix Catalog and Collection type capitalization #96

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

lossyrob
Copy link
Member

@lossyrob lossyrob commented Jul 7, 2021

A LandingPage is a Catalog, and so should have the type field.

Also, the spec says the C of Collection and Catalog should be capitalized.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #96 (951aa92) into master (521ecd8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   96.18%   96.19%           
=======================================
  Files          20       20           
  Lines         472      473    +1     
=======================================
+ Hits          454      455    +1     
  Misses         18       18           
Flag Coverage Δ
unittests 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stac_pydantic/api/landing.py 100.00% <100.00%> (ø)
stac_pydantic/catalog.py 100.00% <100.00%> (ø)
stac_pydantic/collection.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521ecd8...951aa92. Read the comment docs.

@moradology moradology merged commit 3d88955 into master Jul 7, 2021
@gadomski gadomski deleted the fix/rde/landing-page-type branch November 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants