Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset boundaries from center of pixel for landsat #121

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Offset boundaries from center of pixel for landsat #121

merged 1 commit into from
Jun 3, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 2, 2021

Fixes #117.

We use the SR ground sample distance as the bonding box pixel resolution. We do our best to be intelligent about the lat+lon offsets to account for assets near the poles.

@gadomski gadomski added this to the v0.1.6 milestone Jun 2, 2021
@gadomski gadomski requested a review from lossyrob June 2, 2021 14:41
@codecov-commenter
Copy link

Codecov Report

Merging #121 (4742c4f) into master (56deddc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   85.20%   85.26%   +0.06%     
==========================================
  Files          82       82              
  Lines        2453     2463      +10     
==========================================
+ Hits         2090     2100      +10     
  Misses        363      363              
Impacted Files Coverage Δ
...tactools_landsat/stactools/landsat/mtl_metadata.py 95.61% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56deddc...4742c4f. Read the comment docs.

@TomAugspurger
Copy link
Collaborator

Thanks for handling this!

Fixes #117.

We use the SR ground sample distance as the bonding box pixel
resolution. We do our best to be intelligent about the lat+lon offsets
to account for assets near the poles.
@lossyrob lossyrob merged commit e1fcbff into stac-utils:master Jun 3, 2021
@gadomski gadomski deleted the issues/117-landsat-bbox branch June 3, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

landsat8-c2-l2 proj:bbox is off by a half-pixel
4 participants