Fix int conversion #455
Merged
Fix int conversion #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
jorisv
force-pushed
the
topic/fix_int_conversion
branch
2 times, most recently
from
91d0e61
to
cacaf18
Compare
int_conv: Add more integer type binding and add a unit test changelog: Add changelog entry int_conv: Manage int8_t and long on Windows int_conv: Try to use stdint type to manage long hack on windows int_conv: Fix Windows build int_conv: Try to fix Mac build and don't compile twice 64 bits integer on Mac and Windows int_conv: Don't use np.dtypes (introduced in numpy 1.25) int_conv: Test long and int difference in unit test [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci int_conv: Expose long in MacOS int_conv: Don't use deprecated type np.intc int_conv: Fix Mac build int_conv: Remove int128 (doesn't exists) int_conv: Disable long long test on Mac because the type is not reachable int_conv: Begin to work on promotion int_conv: Add unsigned promotion int_conv: Manage complex promotion int_conv: Split matrix binding to avoid memory issue while building int_conv: Split decomposition binding to avoid memory issue while building int_conv: Use clongdouble instead of complex256 int_conv: Avoid out of heap space error on Windows int_conv: Fix test for Mac int_conv: Try to manage longlong on Mac and int on Windows, also reduce compile time int_conv: Manage Windows and Mac int and long long when casting int_conv: Allow scalar to complex conversion int_conv: Manage casting from numpy to eigen with tensor int_conv: Add changelog entries int_conv: Remove conversion from Eigen to Numpy int_conv: Add reference to this PR int_conv: Activate SciPy tests by default
jorisv
force-pushed
the
topic/fix_int_conversion
branch
from
cb528d8
to
670a147
Compare
ManifoldFR
approved these changes
Apr 9, 2024
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Apr 22, 2024
## [3.5.0] - 2024-04-14
### Added
- Allow use of installed JRL-cmakemodule (stack-of-tasks/eigenpy#446)
- Support of Numpy 2.0.0b1 (stack-of-tasks/eigenpy#448)
- Support new primitive type (char, int8_t, uint8_t, int16_t, uint16_t, uint32_t, uint64_t) ()stack-of-tasks/eigenpy#455)
- Support conversion between signed <-> unsigned integers (stack-of-tasks/eigenpy#455)
- Support conversion between complex numbers (stack-of-tasks/eigenpy#455)
### Fixed
- Fix unit test build in C++11 (stack-of-tasks/eigenpy#442)
- Fix unit test function signature [#443](stack-of-tasks/eigenpy#443)
- Fix CMake export (stack-of-tasks/eigenpy#446)
- Fix `int` management on Windows (stack-of-tasks/eigenpy#455)
- Fix `long long` management on Mac (stack-of-tasks/eigenpy#455)
- Allow to run test in the build directory on Windows (stack-of-tasks/eigenpy#457)
### Removed
- Remove casting when converting from Eigen scalar to Numpy scalar.
This should not remove any functionality since Numpy array are created from the Eigen scalar type
(stack-of-tasks/eigenpy#455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #449
Changes
intmanagement on Windows (NPY_INT32 is NPY_LONG, then NPY_INT is never used on Windows)long longmanagement on Mac (NPY_LONGLONG and NPY_LONG are both 64 bits andlongandlong longare the same type on Mac, then there is only one C++ type that must old two different dtype)This should not remove any functionality since Numpy array are created from the Eigen scalar type
Comparison between numpy dtype in Linux/Mac/Windows
Notes
long doublelongis 32 bits where is 64 bits on Mac/Linuxlongis not the same type thanintandint32_t(but it's also a 32 bits integer)long longis not the same type thanlongandint64_t(but it's also a 64 bits integer)longis not the same type thanint64_t(but it's also a 64 bits integer)intandlonglongandlong longare the same C++ typeTODO
Linux table
Mac table
Windows table