Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-path in .gitmodules limits easy access for certain users. #667

Closed
markusgft opened this issue Feb 13, 2019 · 8 comments
Closed

ssh-path in .gitmodules limits easy access for certain users. #667

markusgft opened this issue Feb 13, 2019 · 8 comments
Assignees

Comments

@markusgft
Copy link

Hi all,
when cloning the source-code of the current master, certain users may encounter the following problem: currently, there is a SSH-address hard-coded in ".gitmodules", namely
url = git://github.com/jrl-umi3218/jrl-cmakemodules.git
From within some institutions and universities, it is impossible to access external sources via SSH. It would be great if you could change the URL to
url = https://github.com/jrl-umi3218/jrl-cmakemodules, which avoids unnecessary overhead when cloning pinocchio.

Keep up the great work! :)

@jcarpent
Copy link
Contributor

Ok. Sounds reasonable.
I will fix it now.

@jcarpent
Copy link
Contributor

Solved by #669.

@nim65s
Copy link
Contributor

nim65s commented Feb 13, 2019

For me, the solution is url = ../../jrl-umi3218/jrl-cmakemodules
This way, if you use git clone --recursive https://github.com/stack-of-tasks/pinocchio the submodule will be cloned in https, and if you use git clone --recursive git@github.com:stack-of-tasks/pinocchio the submodule will be cloned in ssh.

@nim65s nim65s reopened this Feb 13, 2019
@jcarpent
Copy link
Contributor

Looks fine to me too.
I will update my PR with it. @nim65s Thanks for this nice detail.

@jcarpent
Copy link
Contributor

Solved by #670.

@markusgft
Copy link
Author

markusgft commented Feb 15, 2019

@jcarpent @nim65s thanks for addressing this issue! Would you mind, however, to also cherry-pick this to the master branch? Would help a lot!

@jcarpent
Copy link
Contributor

@markusgft Sorry, I did not see your comment. I will do that tomorrow.

jcarpent added a commit that referenced this issue Feb 21, 2019
It allows robustifying the cloning procedure
Follows #667 request.
@jcarpent
Copy link
Contributor

@markusgft Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants